clhin

I'd have to respectfully disagree. While we do repeat ourself a little bit here, the current arrangement, in my opinion is confusing. Not only do you have to understand the...

Furthermore, after recent events with Cloudflare, we see that protecting against undefined behavior is not just about past compilers but future ones. There will inevitably come a day where some...

> Not sure if this is a good thing, asprintf will allocate some heap memory uselessly here, where the snprintf wouldn't. This is unfortunately true, but I am not sure...

> Not sure if this is a good thing, asprintf will allocate some heap memory uselessly here, where the snprintf wouldn't. I could try using strcat and then strcopy to...

If there are no further issues with this commit I would like it merged so that we can start thinking about setting -Wextra or -Werror

I tested using strcats as well and they sucessfully compile without the warning, using 3 strcats, one strncpy, and one 108 byte buffer.

I think it makes more sense to make numScreens unsigned, but I went with the least potentially disruptive fix for the ABI's sake

It seems like changing numScreens to unsigned is the optimal solution here. How does one test if an ABI breakage occurs? Just try to run X11 with the proprietary nvidia...

> @X11Libre/dev @metux @Soccera1 ping anything missing here? Code review and merge times leave a bit to be desired in this project... I get people are busy but if X11...

[Turns out this is a protocol violation unforunately.](https://www.x.org/releases/X11R7.7/doc/kbproto/xkbproto.html#Locking_and_Latching_Modifiers_and_Groups:~:text=Key%20release%20has%20no%20effect.) There really isn't much wiggle room here either. It says in plain english that is the behavior. So we would have to...