cya
cya copied to clipboard
cleverwise
Adds FlowFreeze contract
Adds FlowFreeze contract, which maintains a list of accounts that are frozen that an admin, the service account, controls.
The admin can freeze and unfreeze accounts at will. There is a public function to get the list of frozen accounts
Adds some tests to test freezing and unfreezing
I was waiting for the freezing ability to be included in the emulator: https://github.com/onflow/flow-go/pull/329 before I moved forward with this, but I'm not sure if this is still the kind of contract we want. Do you know if we still need this?
AFAIK, we can already freeze accounts with just a tx, without a contract, but maybe i'm missing something.
@Kay-Zee I think we thought it might be useful to have the frozen information easily accessible in a smart contract so it was more transparent and also emits events, but I don't know if those goals have changed? Who is in charge of this? Should we check with them?
@Kay-Zee @laynelafrance Do we still need this? This has been open for a long time and I'm not sure what we plan to do with it
Who is the admin and under what circumstances can they Freeze a users account?
Is this documented anywhere?
On Tue, 15 Jun 2021, 22:55 Joshua Hannan, @.***> wrote:
@Kay-Zee https://github.com/Kay-Zee @laynelafrance https://github.com/laynelafrance Do we still need this? This has been open for a long time and I'm not sure what we plan to do with it
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/onflow/flow-core-contracts/pull/112#issuecomment-861620066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3PL7P6QHLBGDNMZ3DR23TS5ZXFANCNFSM4WXVZRIQ .
@justjoolz The admin is the service account, which already has been partially decentralized (4 different parties control keys for it other than dapper labs and the account needs two signatures to sign a transaction) This is only planned to be used if there is an account that is trying to do something obviously malicious to the network while we are still in the early non-BFT phases of Flow's development. Therefore, we don't expect to ever use it and really don't want to ever use it.
I'm going to close this PR because it is not needed anymore as the Freezing functionality is being removed