javascript icon indicating copy to clipboard operation
javascript copied to clipboard

feat(ui,clerk-js,shared): Surface organization creation defaults to components

Open LauraBeatris opened this issue 2 months ago β€’ 2 comments

Description

Resolves ORGS-1027, ORGS-1136

Checklist

  • [X] pnpm test runs as expected.
  • [X] pnpm build runs as expected.
  • [ ] (If applicable) JSDoc comments have been added or updated for any package exports
  • [ ] (If applicable) Documentation has been updated

Type of change

  • [ ] πŸ› Bug fix
  • [ ] 🌟 New feature
  • [ ] πŸ”¨ Breaking change
  • [ ] πŸ“– Refactoring / dependency upgrade / documentation
  • [ ] other:

LauraBeatris avatar Dec 17 '25 01:12 LauraBeatris

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 19, 2025 3:32pm

vercel[bot] avatar Dec 17 '25 01:12 vercel[bot]

⚠️ No Changeset found

Latest commit: 22edba6ce46e5da67e9c6b5171f3042e6ed25459

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 17 '25 01:12 changeset-bot[bot]

πŸ“ Walkthrough

Walkthrough

This pull request implements organization creation defaults functionality across the Clerk JavaScript SDK and UI components. It introduces new type definitions for organization creation defaults with advisory capabilities, adds a new resource class to fetch these defaults from an API endpoint, and extends existing organization settings to track whether this feature is enabled. The TaskChooseOrganization screen is updated to conditionally fetch and display these defaults when enabled, including pre-filling form fields with default values and rendering advisory alerts when existing organizations are detected for a user's email domain. Supporting changes include fixture helpers for testing, new localization strings, and UI component enhancements for avatar uploading and form pre-population.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
βœ… Passed checks (4 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check βœ… Passed The PR comprehensively addresses both ORGS-1027 and ORGS-1136 objectives: new types added to @clerk/shared/types, clerk-js resources updated to consume defaults, conditional fetching based on enabled flag implemented, default naming/logo rendered in TaskChooseOrganization with warning alerts.
Out of Scope Changes check βœ… Passed All changes are directly scoped to implementing organization creation defaults: type definitions, resource classes, UI components for alerts and form prefilling, test fixtures, and localization strings. A minor adjustment to AvatarUploader appears supportive of the avatar upload feature.
Title check βœ… Passed The title accurately describes the main change: introducing organization creation defaults to UI, clerk-js, and shared packages as a new feature.

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 19 '25 15:12 coderabbitai[bot]

I'll hold merging this one after the winter break

LauraBeatris avatar Dec 19 '25 15:12 LauraBeatris