javascript icon indicating copy to clipboard operation
javascript copied to clipboard

orgs-236: wip

Open NicolasLopes7 opened this issue 1 year ago • 1 comments

Description

Checklist

  • [ ] npm test runs as expected.
  • [ ] npm run build runs as expected.
  • [ ] (If applicable) JSDoc comments have been added or updated for any package exports
  • [ ] (If applicable) Documentation has been updated

Type of change

  • [ ] 🐛 Bug fix
  • [ ] 🌟 New feature
  • [ ] 🔨 Breaking change
  • [ ] 📖 Refactoring / dependency upgrade / documentation
  • [ ] other:

NicolasLopes7 avatar Oct 24 '24 21:10 NicolasLopes7

🦋 Changeset detected

Latest commit: 315276c4483081d92b3ad76d7fa3849a83c663d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/types Minor
@clerk/localizations Minor
@clerk/clerk-js Minor
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 24 '24 21:10 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:52am

vercel[bot] avatar Dec 02 '24 22:12 vercel[bot]

@brkalow @NicolasLopes7 @LauraBeatris In the video demo we can see that we are loosing the state of the modal when the user returns back to the app. We do have this mechanism in place for OAuth connections via the UserProfile, do you think we should add it to this new flow as well ?

panteliselef avatar Jan 16 '25 08:01 panteliselef

@panteliselef I introduced changes on https://github.com/clerk/javascript/pull/4406/commits/65231ce62af8fc4943d0afc80b406fb15ffe016e to preserve the UserProfile modal state upon SSO redirection

I've updated the PR description with a video - disclaimer: the enterprise account icon is broken since our staging CDN doesn't have that asset, but it works for production

LauraBeatris avatar Jan 17 '25 20:01 LauraBeatris

Updated UI to rely on button click to kick-off the verification flow, instead of using window.open:

LauraBeatris avatar Jan 21 '25 19:01 LauraBeatris