javascript icon indicating copy to clipboard operation
javascript copied to clipboard

fix(clerk-js): Calculation of existence of valid auth factors

Open chanioxaris opened this issue 3 years ago • 0 comments

Type of change

  • [x] 🐛 Bug fix
  • [ ] 🌟 New feature
  • [ ] 🔨 Breaking change
  • [ ] 📖 Refactoring / dependency upgrade / documentation
  • [ ] other:

Packages affected

  • [x] @clerk/clerk-js
  • [ ] @clerk/clerk-react
  • [ ] @clerk/nextjs
  • [ ] @clerk/remix
  • [ ] @clerk/types
  • [ ] @clerk/themes
  • [ ] @clerk/clerk-expo
  • [ ] @clerk/backend-core
  • [ ] @clerk/clerk-sdk-node
  • [ ] @clerk/edge
  • [ ] build/tooling/chore

Description

  • [x] npm test runs as expected.
  • [x] npm run build runs as expected.

That commit fixes a bug on the calculation of a valid auth factor. We use this information to determine to render the sign up form or not. The 'used_for_first_factor' attribute field doesn't have to do with the sign up flow, so we change the relevant code to check if the corresponding attributes are enabled or not

Before

https://user-images.githubusercontent.com/22435234/195612147-9c4fec5f-2fc8-4aa4-be7b-2b011992d562.mov

After

https://user-images.githubusercontent.com/22435234/195612084-28761736-3019-4650-afc2-626d44841212.mov

https://www.notion.so/clerkdev/Fix-PSU-with-required-emails-when-using-Sign-in-with-Metamask-32ef5f2f7261407cb3136b877fb20133

chanioxaris avatar Oct 13 '22 13:10 chanioxaris