javascript icon indicating copy to clipboard operation
javascript copied to clipboard

ci(repo): Run CI workflow on `pull_request_target`

Open LauraBeatris opened this issue 1 year ago • 1 comments

Description

Resolves SDK-1253

CI is failing (example) on some PRs from forked repositories due to repo secrets not being available.

Refer to the documentation for Using encrypted secrets in a workflow: "With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository."

Checklist

  • [x] npm test runs as expected.
  • [x] npm run build runs as expected.
  • [ ] (If applicable) JSDoc comments have been added or updated for any package exports
  • [ ] (If applicable) Documentation has been updated

Type of change

  • [ ] 🐛 Bug fix
  • [ ] 🌟 New feature
  • [ ] 🔨 Breaking change
  • [x] 📖 Refactoring / dependency upgrade / documentation
  • [ ] other:

LauraBeatris avatar Jun 04 '24 19:06 LauraBeatris

⚠️ No Changeset found

Latest commit: ef44f2d42606f2515e640ab1bb5905f68732f3d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 04 '24 19:06 changeset-bot[bot]

I'll close this as it seems we've already solved the case by triggering the workflows on the PR.

LauraBeatris avatar Aug 27 '24 16:08 LauraBeatris