javascript icon indicating copy to clipboard operation
javascript copied to clipboard

feat(clerk-js): Add dev mode notice to components

Open desiprisg opened this issue 1 year ago • 9 comments

Description

Add a dev mode notice to our components to avoid going to prod with dev keys on accident. image image

Checklist

  • [x] npm test runs as expected.
  • [x] npm run build runs as expected.
  • [ ] (If applicable) JSDoc comments have been added or updated for any package exports
  • [ ] (If applicable) Documentation has been updated

Type of change

  • [ ] 🐛 Bug fix
  • [x] 🌟 New feature
  • [ ] 🔨 Breaking change
  • [ ] 📖 Refactoring / dependency upgrade / documentation
  • [ ] other:

desiprisg avatar Jun 04 '24 10:06 desiprisg

🦋 Changeset detected

Latest commit: 79dd3a94489e090d1c63578ec470d0b293584751

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/astro Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 04 '24 10:06 changeset-bot[bot]

!preview

desiprisg avatar Jun 04 '24 10:06 desiprisg

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
:cookie: Deployed Visit preview Jul 31, 2024 10:09 AM

clerk-cookie avatar Jun 04 '24 10:06 clerk-cookie

!preview

desiprisg avatar Jun 04 '24 10:06 desiprisg

@desiprisg can we have a screenshot of how this looks like?

anagstef avatar Jun 05 '24 16:06 anagstef

@desiprisg can we have a screenshot of how this looks like?

Adding these! Feel free to check the preview deployment as well!

desiprisg avatar Jun 05 '24 18:06 desiprisg

Hey @desiprisg , whats the status of this one?

nikosdouvlis avatar Jun 10 '24 11:06 nikosdouvlis

Hey @desiprisg , whats the status of this one?

We were waiting for user button / org switcher designs before merging this one.

desiprisg avatar Jun 14 '24 21:06 desiprisg

!preview

octoper avatar Jun 26 '24 11:06 octoper

@octoper hey :) is this good to go? if not, do you need help with anything at this point?

nikosdouvlis avatar Jul 11 '24 17:07 nikosdouvlis

There were no designs for <OrgSwitcher/> and <UserButton/> until yesterday, I will take a look at this today

octoper avatar Jul 11 '24 17:07 octoper

!preview

octoper avatar Jul 12 '24 00:07 octoper

!preview

octoper avatar Jul 12 '24 14:07 octoper

@octoper do we offer the ability for a developer to turn this off in Dev?

kylemac avatar Jul 14 '24 20:07 kylemac

!preview

octoper avatar Jul 18 '24 20:07 octoper

!preview

octoper avatar Jul 19 '24 05:07 octoper

!preview

octoper avatar Jul 25 '24 12:07 octoper

!preview

octoper avatar Jul 25 '24 15:07 octoper

!snapshot

anagstef avatar Jul 26 '24 11:07 anagstef

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 0.0.3-snapshot.v2af7822
@clerk/backend 1.3.2-snapshot.v2af7822
@clerk/chrome-extension 1.1.4-snapshot.v2af7822
@clerk/clerk-js 5.9.0-snapshot.v2af7822
@clerk/elements 0.10.3-snapshot.v2af7822
@clerk/clerk-expo 1.2.7-snapshot.v2af7822
@clerk/express 0.0.17-snapshot.v2af7822
@clerk/fastify 1.0.19-snapshot.v2af7822
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/localizations 2.4.8-snapshot.v2af7822
@clerk/nextjs 5.2.4-snapshot.v2af7822
@clerk/clerk-react 5.2.8-snapshot.v2af7822
@clerk/remix 4.2.3-snapshot.v2af7822
@clerk/clerk-sdk-node 5.0.16-snapshot.v2af7822
@clerk/shared 2.3.3-snapshot.v2af7822
@clerk/tanstack-start 0.1.7-snapshot.v2af7822
@clerk/testing 1.1.11-snapshot.v2af7822
@clerk/themes 2.1.12-snapshot.v2af7822
@clerk/types 4.8.0-snapshot.v2af7822

Tip: Use the snippet copy button below to quickly install the required packages. @clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

clerk-cookie avatar Jul 26 '24 11:07 clerk-cookie

!preview

PixelJanitor avatar Jul 30 '24 18:07 PixelJanitor

!preview

nikosdouvlis avatar Jul 30 '24 23:07 nikosdouvlis

@PixelJanitor something's up with the GH comments, but here's your preview link: https://javascript-preview-3511.clerkpreview.com/

nikosdouvlis avatar Jul 30 '24 23:07 nikosdouvlis

@nikosdouvlis @PixelJanitor needs to ensure his Clerk membership status is set to public for !preview and !snapshot comments to function https://github.com/clerk/javascript/blob/main/docs/PUBLISH.md#previewing-prs

alexcarpenter avatar Jul 31 '24 00:07 alexcarpenter

@alexcarpenter that's true, but the comment is missing even though the action I triggered was completed successfully: https://github.com/clerk/javascript/actions/runs/10171336607/job/28132106414

nikosdouvlis avatar Jul 31 '24 08:07 nikosdouvlis

@nikosdouvlis @alexcarpenter The comment is only posted once and gets updated when !preview deployment is done, also the URL of the preview remains the same

octoper avatar Jul 31 '24 10:07 octoper

!preview

octoper avatar Jul 31 '24 10:07 octoper