javascript icon indicating copy to clipboard operation
javascript copied to clipboard

fix(clerk-js): Update existing `SignUp` object on `SignUpContinue` OAuth

Open LauraBeatris opened this issue 1 year ago • 1 comments

Description

Resolves SDK-1689 - fixes Web3 sign-up flow with social connections.

The SDK was creating a new SignUp object on OAuth callback when continuing a signup flow, overriding properties such as web3_wallet.

Instead of creating a new SignUp object, it should update the existing one.

Checklist

  • [X] npm test runs as expected.
  • [X] npm run build runs as expected.
  • [ ] (If applicable) JSDoc comments have been added or updated for any package exports
  • [ ] (If applicable) Documentation has been updated

Type of change

  • [X] 🐛 Bug fix
  • [ ] 🌟 New feature
  • [ ] 🔨 Breaking change
  • [ ] 📖 Refactoring / dependency upgrade / documentation
  • [ ] other:

LauraBeatris avatar May 17 '24 17:05 LauraBeatris

🦋 Changeset detected

Latest commit: c1a59fbf3cff27263c7f3ae8c9d377d2a0a75f3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 17 '24 17:05 changeset-bot[bot]