javascript icon indicating copy to clipboard operation
javascript copied to clipboard

chore(testing): Add experimental console warning on Cypress setup

Open anagstef opened this issue 9 months ago • 3 comments

Description

This PR adds the following console message on the node process that runs the clerkSetup function from @clerk/testing/cypress:

@clerk/testing: Cypress is an experimental project and subject to change in the future.

Checklist

  • [x] npm test runs as expected.
  • [x] npm run build runs as expected.
  • [ ] (If applicable) JSDoc comments have been added or updated for any package exports
  • [ ] (If applicable) Documentation has been updated

Type of change

  • [x] 🐛 Bug fix
  • [ ] 🌟 New feature
  • [ ] 🔨 Breaking change
  • [ ] 📖 Refactoring / dependency upgrade / documentation
  • [ ] other:

anagstef avatar May 16 '24 15:05 anagstef

🦋 Changeset detected

Latest commit: 3a21c155abfe14535bb0c1d274cccf15890e0a2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 16 '24 15:05 changeset-bot[bot]

I am fine with this, but why didn't we lunch this in @clerk/testing/experimental/cypress?

@panteliselef it's a bit complicated. The actual package is not experimental, the Clerk + Cypress integration is. The log will be easily removed when we validate it's fully supported.

anagstef avatar May 16 '24 16:05 anagstef

@anagstef an idea would be to have both

  • @clerk/testing/experimental/cypress
  • @clerk/testing/playwrite

Just because i think warning in tests are usually overlooked

panteliselef avatar May 16 '24 16:05 panteliselef

@anagstef an idea would be to have both

  • @clerk/testing/experimental/cypress
  • @clerk/testing/playwrite

Just because i think warning in tests are usually overlooked

@panteliselef The point I was trying to make is that when we fully support Cypress, no actions will be needed for this package. This package just implements testing tokens, which works as expected. This warning is just informative about the Cypress support in general.

anagstef avatar May 17 '24 11:05 anagstef