javascript icon indicating copy to clipboard operation
javascript copied to clipboard

feat(test): Add Clerk Elements E2E

Open LekoArts opened this issue 9 months ago • 1 comments

Description

This PR adds Playwright E2E tests for Clerk Elements. Included are:

  • next-sign-in.test.ts - Mirrors the existing sign-in-flow.test.ts file to assert that one can successfully sign in
  • next-sign-up.test.ts - Mirrors the existing sign-up-flow.test.ts file to assert that one can successfully sign up
  • otp.test.ts - Assert that <Input type="otp" /> works correctly
  • validate-password.test.ts - Assert that <Input type="password" validatePassword /> works correctly

Moreover, this PR also fixes this Faker.js deprecation message:

[@faker-js/faker]: faker.phone.number(format) is deprecated since v8.1 and will be removed in v9.0. Please use faker.phone.number() instead.

This issue explains how to use replaceSymbolWithNumber but that's also deprecated and its docs explain what to use instead.

Fixes SDK-1721 Fixes SDK-1382

Checklist

  • [x] npm test runs as expected.
  • [x] npm run build runs as expected.
  • [ ] (If applicable) JSDoc comments have been added or updated for any package exports
  • [ ] (If applicable) Documentation has been updated

Type of change

  • [ ] 🐛 Bug fix
  • [ ] 🌟 New feature
  • [ ] 🔨 Breaking change
  • [ ] 📖 Refactoring / dependency upgrade / documentation
  • [x] other: E2E tests

LekoArts avatar May 16 '24 13:05 LekoArts

🦋 Changeset detected

Latest commit: ff3e23f1d10eeadf61079ae63030727339b8a31b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 16 '24 13:05 changeset-bot[bot]