javascript
javascript copied to clipboard
chore(clerk-react): Send telemetry events for React hooks
Description
Resolves SDK-1672
Sends telemetry events for React hooks. This will be useful to track regarding the creation of custom flows with hooks such as useSignUp
.
Checklist
- [ ]
npm test
runs as expected. - [ ]
npm run build
runs as expected. - [ ] (If applicable) JSDoc comments have been added or updated for any package exports
- [ ] (If applicable) Documentation has been updated
Type of change
- [ ] 🐛 Bug fix
- [X] 🌟 New feature
- [ ] 🔨 Breaking change
- [ ] 📖 Refactoring / dependency upgrade / documentation
- [ ] other:
🦋 Changeset detected
Latest commit: 6dbb515aee42559ad372613cdc9e4da423a1e15d
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 6 packages
Name | Type |
---|---|
@clerk/clerk-react | Patch |
@clerk/chrome-extension | Patch |
@clerk/clerk-expo | Patch |
gatsby-plugin-clerk | Patch |
@clerk/nextjs | Patch |
@clerk/remix | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
We should not emit events for all hooks. We need to consider what particular insights each hook would give us, and whether it's useful.
I advocate for sending events from useSignIn
and useSignUp
, is cause those give us insights into custom flows, eg: How this would react when Clerk Elements get released.
Edit: @panteliselef also mentioned that tracking organizations might be useful to have a sense for custom organization flows.
Blocking this PR as I'm still deciding on how to move forward with recordings events in code hot-paths.
Edit: We're going to move forward with introducing client-side caching. I'll open another PR for this.
Also closing this one in order to open later directly from the repo instead of a forked branch.