Clément Charmet

Results 140 comments of Clément Charmet

It does, actually: no more `js.node` I should probably dump some other stuff such as `JQuery`

Hi, Unfortunately the project has not been very active for the last few years. Also, historically, haxe-js-kit had its own nodejs externs, which may explain lack of unification here and...

Life's great, I hope it's the same for you ;) I think what's leaking here is a maintainer, at least; I'm not sure money would help.

Hi @TheoSabattie The issue seems related to https://github.com/clemos/haxe-js-kit/issues/179 The problem is most probably in the same macro. Unfortunately I have no time to look into it at the moment.

I guess you can start by adding the needed signatures (for example, add `discriminatorKey` in `SchemaOptions` : https://github.com/clemos/haxe-js-kit/blob/develop/js/npm/mongoose/Schema.hx#L36-L52) Then I don't really know how it could fit with macros, as...

You should be able to do: `choiceMd = md.discriminator("FilterTypeChoice", FilterTypeChoice.Schema);`

If you tested it, then I guess it's fine. I just wonder if your `FilterTypeChoice.Schema` contains the `title` field, which would be wrong (?). But ITOH when not using disciminator,...

Can you please make a PR with your test in https://github.com/clemos/haxe-js-kit/tree/master/test/buddy/src ? It's indeed always difficult to keep JS's flexibility while typing stuff as much as possible, especially with method...

I'm aware of this issue, and not sure how to deal with it either. The solution on my end is obvious: I should move browser libs to a separate lib...

> the build size will increase, because you're shipping the nodejs-based version in the browser We could have something like that, with minimal overhead for browsers (pseudocode, obviously) : ```...