TE-Aid icon indicating copy to clipboard operation
TE-Aid copied to clipboard

Adding a bioconda recipe

Open bricoletc opened this issue 2 years ago • 6 comments

Hello, I recently tried your tool, found it useful, and thought it'd be good to release it on bioconda! If you're interested, I got put in a PR to bioconda to add a recipe for this tool.

One thing that would be needed is providing release tarballs on this repo

Best

bricoletc avatar Dec 06 '23 16:12 bricoletc

Hey! That would be amazing!

So basically I should create a release based on the GitHub repo? I might add a few quality of life improvement before (such as the ability to run on multiple sequences at a time).

Let me know if there are some specifics that needs to be in the tarball release, and I'll be happy to do it!

Cheers,

Clément

clemgoub avatar Dec 06 '23 17:12 clemgoub

Sounds good, I will have a go at making/testing the recipe and update here
I would say, because they're easily update-able, that a first release based on current tip of main branch is already great

And will update you about the specifics of tarball release! Best

bricoletc avatar Dec 14 '23 10:12 bricoletc

@clemgoub we're missing (at least) two things:

  • A LICENCE file with the licence of your choice (I personally use MIT a lot)
  • Pushing a tag with a first-release version number for the repo; I would have chosen v0.1.0 personally, but it depends on your assessment of how much the CLI args/API will change, see here Then making a first release on your main repo using that tag, as done here

bricoletc avatar Dec 22 '23 11:12 bricoletc

I've created a PR! https://github.com/bioconda/bioconda-recipes/pull/44954 I will update it with licence, version and release tarball when those are added by yourself

bricoletc avatar Dec 22 '23 12:12 bricoletc

Hi there!

Sorry I didn't communicate more since our last chat. I am still interested to build a bioconda recipe for TE+Aid. FYI, @foriin recently added a .yml to support creation of a conda environment. Whether those changes affect your PR, I would like to check with you before continuing. If I understand correctly, we'll still need the LICENSE, version and release tarball right?

I'm sorry for the delays and I praise you patience!

Best,

Clément

clemgoub avatar Mar 26 '24 13:03 clemgoub

Hello! Yes, we still a need LICENCE, version and release tarball.

It seems that it's standard to pin dependencies in the bioconda recipe meta.yaml, as I've done in my PR; however, that's a bit redundant with the TE_Aid.yaml in this repo. I'm not sure if there's a way to use the dependencies specified in TE_Aid.yaml during building of the bioconda package. Either way, shall I update the requirements of the bioconda recipe to match those in TE_Aid.yaml?

Best!

bricoletc avatar Mar 27 '24 14:03 bricoletc

Hi @clemgoub, I'd like to use TE-Aid as a dependency of another bioconda project so it would be great to get @bricoletc 's recipe up.

# Add tag
git tag -a v0.1.0 -m "Initial release"
#push to github
git push origin --tags

Adamtaranto avatar Mar 03 '25 03:03 Adamtaranto

Hello @Adamtaranto @bricoletc, sorry for the radio silence on this. I would like to get this going indeed. @bricoletc, whenever you are able to implement the biostrings dep, I can create the release with license, tag and tarball.

Cheers,

Clément

clemgoub avatar Mar 03 '25 16:03 clemgoub

Hi @clemgoub, thanks for the quick reply. Changes to the bioconda recipe can be made independently of the release here if you want to go ahead with that.

Adamtaranto avatar Mar 03 '25 20:03 Adamtaranto

Ok, I'm doing the release.

clemgoub avatar Mar 03 '25 21:03 clemgoub

it's here -- hope all is good otherwise let me know!

clemgoub avatar Mar 03 '25 21:03 clemgoub

@clemgoub, sorry, would you mind removing that tag and release and re-doing it without the extra dot after the v?

i.e. v.1.0.0 --> v1.0.0

It will confuse the pattern that bioconda uses to search for new versions otherwise.

Adamtaranto avatar Mar 04 '25 04:03 Adamtaranto

Absolutely, sorry about that I'm doing it ASAP!

clemgoub avatar Mar 04 '25 17:03 clemgoub

Thanks. Bioconda recipe is good to go once the corrected release is up.

Adamtaranto avatar Mar 05 '25 06:03 Adamtaranto

There you have it! https://github.com/clemgoub/TE-Aid/releases/tag/v1.0.0

clemgoub avatar Mar 05 '25 20:03 clemgoub

Thank you for working on this recipe! 🤗

clemgoub avatar Mar 05 '25 20:03 clemgoub

Cheers, submitted for review! Thanks @bricoletc

Adamtaranto avatar Mar 05 '25 21:03 Adamtaranto

This is great, thanks for pushing to completion @Adamtaranto , all the best @clemgoub !

bricoletc avatar Mar 06 '25 07:03 bricoletc

Thanks a lot guys! Sorry for the delays! :dna:

clemgoub avatar Mar 06 '25 16:03 clemgoub