scrapy-selenium icon indicating copy to clipboard operation
scrapy-selenium copied to clipboard

Published 20 hours ago • verified publisher icon clemfromspace

Fixes TypeError: __init__() got an unexpected keyword argument 'firefox_options'

Open abhinav-bhardwaj opened this issue 3 years ago • 14 comments

Fixes #100

Tested on Selenium Version - 4.0.0 scrapy-selenium version - 0.0.7 Scrapy version - 2.5.1 Python version - 3.8 OS - Ubuntu 20.04.2 LTS

abhinav-bhardwaj avatar Oct 15 '21 10:10 abhinav-bhardwaj

I want to use options (for example, '-headless'), but now they are ignored.

RomanBukin avatar Oct 15 '21 13:10 RomanBukin

I want to use options (for example, '-headless'), but now they are ignored.

Did you try the latest code update that I have committed?

abhinav-bhardwaj avatar Oct 17 '21 14:10 abhinav-bhardwaj

Thanks for this, works like a charm after the file change.

Zincious avatar Nov 06 '21 15:11 Zincious

Did you try the latest code update that I have committed?

Yes, now it works. Thanks.

RomanBukin avatar Nov 24 '21 07:11 RomanBukin

While waiting on this to be merged ... which version of selenium & scrapy-selenium don't have this issue? thanks

damienkilgannon avatar Dec 02 '21 12:12 damienkilgannon

so, problem is in selenium version:

the browser option parameter firefox_options was deprecated in Selenium 3.8.0

If you use newest version: i tested the package today - the problem is in place.

KonstantinKlepikov avatar Jan 20 '22 16:01 KonstantinKlepikov

Hello! Any chance for this to get merged?

k0mmsussert0d avatar Feb 20 '22 23:02 k0mmsussert0d

@clemfromspace any idea when this will be merged and updated?

samlexxy avatar Aug 17 '22 06:08 samlexxy

This PR should be merged as soon as possible. it is critical. ^ ^

wunewww avatar Nov 01 '22 00:11 wunewww

@abhinav-bhardwaj can you please review and merge this?

samlexxy avatar Nov 01 '22 17:11 samlexxy

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

abhinav-bhardwaj avatar Nov 01 '22 18:11 abhinav-bhardwaj

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

perhaps @clemfromspace will be kind enough to look into this

samlexxy avatar Nov 02 '22 04:11 samlexxy

self.driver = driver_klass(**driver_kwargs) TypeError: WebDriver.init() got an unexpected keyword argument 'executable_path' ANY SOLUTUION?

ahmedraxa23 avatar Jun 20 '23 08:06 ahmedraxa23

self.driver = driver_klass(**driver_kwargs) TypeError: WebDriver.init() got an unexpected keyword argument 'executable_path' ANY SOLUTUION?

you'll need to edit your scrapy_selenium middle file..

follow this link https://github.com/clemfromspace/scrapy-selenium/pull/101/files

samlexxy avatar Jun 21 '23 03:06 samlexxy