MetroDNA icon indicating copy to clipboard operation
MetroDNA copied to clipboard

bug: does not show up on google chrome 72 and strict ie

Open sbounmy opened this issue 5 years ago • 3 comments

fix: encode svg url so it displays correctly

Reproduced by: https://stackoverflow.com/questions/54453987/did-chrome-72-break-dataimage-svgxmlutf8-for-css-background-svgs

More detailed explaination: https://codepen.io/tigt/post/optimizing-svgs-in-data-uris

Might want to apply on metrodna.min.css too

sbounmy avatar May 07 '19 14:05 sbounmy

fixed the issue for me (y)

frenchcharly avatar May 22 '19 17:05 frenchcharly

Hi ! Thanks for the PR, I did not know about the issue so I'm glad you fixed it :)

However I can't merge your PR right now because I need to update the .scss and .min.css file as well to make sure that they all contains the same code.

I just added an npm script on the master branch of the repo to generate the .css and the .min.css files from the .scss file. Could you update your fork and your branch, add your fix to the scss file, run the script (npm run scss), and then commit this ?

Then I'll be able to merge your work. Thanks !

Clement

clementoriol avatar May 23 '19 08:05 clementoriol

By the way since you guys are using the library I'd love your input on this too : https://github.com/clementoriol/MetroDNA/issues/20

Thanks

clementoriol avatar May 23 '19 08:05 clementoriol