clementine-player
"Shuffle Album" mode doesn't work when clementine was just started
When you have the "Shuffle Album" mode selected, and Clementine just starts up, it will play the first track of the album and then randomly choose another album.
This also happens, when you switch the playlist. It plays the first track of the album fine, but then randomly chooses another one.
Thanks for that great music player :+1:
I'm not sure if this important, but the playlist I'm talking about is usually very long, 14440 tracks for example.
I was able to reproduce this (V1.2.3) and I didn't even had to wait for the track to end, just hitting next did what is described. There was an (even) odd behavior, but I'll have to test a little more (in GIT version), then I'll try to give it a look.
Ok, I've been checking this issue out, and I need some expected behavior when a couple of situations happen:
- Clementine starts up and previously the "shuffle album" mode was set and simply hit play (on the selected track - the discussed case)
- Clementine is running and no track is paused or playing (but a track is selected). You change the shuffle mode to "shuffle album", where previously a different mode was selected, and hit play (no double click).
What I think it should happen in both cases is that it should prioritize the correspondent selected track album. What do you guys think? @robotanarchy @ArnaudBienner
Best Regards!
Thanks for checking it out, Mikah89!
I would Clementine expect to play the album in both cases.
Also in both cases I would expect Clementine to play from the selected track, not the first track of the album.
So, I've been doing some tests, and it seems the semantic of selected song is a bit different of what I thought.
It seems a selection is with a double click, what I mean is that a selection is not when you just one click the track (highlighting the track) but when you double click or right click on the track and choose play. That will be the selected track until the song ends or you double click another track. In practice what this does is, when you shutdown clementine with a selected song, with the semantic I just explained, and reopen again it will start playing the track that was playing before when you press play, regardless of which track you just one clicked. So the second situation I mentioned is kinda not valid at the moment. But anyways this would be another issue (if it even is an issue).
Related to the issue in question I think I managed to arrange something.
Unfortunately, it seems as this issue is not yet fully fixed.
I installed version 1.2.3-1346-gcc1b504 from clementine-dev (https://launchpad.net/~me-davidsansome/+archive/ubuntu/clementine-dev). And I experience the following behavior:
- Set the shuffle mode to "Shuffle by album"
- Start playing the playlist (let's assume we play "Song 3" from "Album 7")
- Quit Clementine
- Start Clementine
- Resume the playlist (even though I have configured Clementine to always resume playback on start, I have to resume manually by clicking the play button)
- After Song 3 from Album 7 finished, it plays always Song 1 from Album 7, then Song 2 from Album 7 and so on. Interestingly, after Song 6, it skips Song 7 and plays Song 8 of Album 7.
Maybe this defect has been introduced by some other commit ...
Can someone confirm this behavior?
yes, can confirm (tested with Clementine 1.3.1 on both OS X 10.11.6 and Linux Mint 18.1).
to add to what was already described: once in shuffle album mode, it will play the song that you double-click but then continue from the 1st song of the album (instead of the song that would follow the double-clicked one), ONLY if nothing was playing before (i.e. you just started the program OR stopped the playback via the stop button). that is, once something is playing and you double click on any song to start it, it will continue with the expected behavior and not the bug described here.
thanks a lot for all your efforts with clementine!
