libTAS icon indicating copy to clipboard operation
libTAS copied to clipboard

Include executable path and command line options in movie file

Open Randomno opened this issue 1 year ago • 6 comments

#551

Randomno avatar Aug 27 '23 20:08 Randomno

Saving the full game path will expose some of people's file architecture, including their username. Some people may not want to show that?

clementgallet avatar Aug 31 '23 14:08 clementgallet

The username is often exposed as the owner of the ltm. But the need to include the whole file path is still uncertain. I asked on Discord about this before: https://discord.com/channels/726811446498820198/726811447262183477/1145440660523069450

Randomno avatar Aug 31 '23 16:08 Randomno

If only the executable name is included this should be universally safe to go.

vadosnaprimer avatar Jun 28 '24 18:06 vadosnaprimer

I'm fine to change this to game name and command line arguments (if that's what was meant). But command line args are also going to expose users' file paths for a significant proportion of movies.

Randomno avatar Jun 28 '24 18:06 Randomno

Well after having judged a whole bunch of libTAS movies, I don't remember having problems with verifying the arguments part. It's already kinda rare to begin with, and when it's needed, it's usually the only way to run the thing, and authors mention it in the description.

vadosnaprimer avatar Jun 28 '24 19:06 vadosnaprimer

If only the executable name is included this should be universally safe to go.

Oh and it already is! https://github.com/clementgallet/libTAS/blob/c890635d47748b3d5e480b2a552ef2724fbdaf87/src/program/movie/MovieFileHeader.cpp#L133

vadosnaprimer avatar Jun 30 '24 20:06 vadosnaprimer