libTAS
libTAS copied to clipboard
Include executable path and command line options in movie file
#551
Saving the full game path will expose some of people's file architecture, including their username. Some people may not want to show that?
The username is often exposed as the owner of the ltm. But the need to include the whole file path is still uncertain. I asked on Discord about this before: https://discord.com/channels/726811446498820198/726811447262183477/1145440660523069450
If only the executable name is included this should be universally safe to go.
I'm fine to change this to game name and command line arguments (if that's what was meant). But command line args are also going to expose users' file paths for a significant proportion of movies.
Well after having judged a whole bunch of libTAS movies, I don't remember having problems with verifying the arguments part. It's already kinda rare to begin with, and when it's needed, it's usually the only way to run the thing, and authors mention it in the description.
If only the executable name is included this should be universally safe to go.
Oh and it already is! https://github.com/clementgallet/libTAS/blob/c890635d47748b3d5e480b2a552ef2724fbdaf87/src/program/movie/MovieFileHeader.cpp#L133