async
async copied to clipboard
read_start bug in luv
Relevant to async. Memory still leaks. I am just calling uv.read_stop explicitly (in handle.lua), once reading has started, before shutting down.
https://github.com/creationix/luv/issues/22
It's a hacky way, but it solves leaking. If you want I can send in a pull request.
So inserting uv.read_stop()
there solves the problem right?
yes, pretty much wherever uv.close is called if you add if h.reading then uv.read_stop(h) end
https://github.com/soumith/async/commit/0cbe855385d82040ee4282c38313b4385a10ec4a