async icon indicating copy to clipboard operation
async copied to clipboard

read_start bug in luv

Open soumith opened this issue 11 years ago • 3 comments

Relevant to async. Memory still leaks. I am just calling uv.read_stop explicitly (in handle.lua), once reading has started, before shutting down.

https://github.com/creationix/luv/issues/22

It's a hacky way, but it solves leaking. If you want I can send in a pull request.

soumith avatar Feb 02 '14 05:02 soumith

So inserting uv.read_stop() there solves the problem right?

clementfarabet avatar Feb 02 '14 17:02 clementfarabet

yes, pretty much wherever uv.close is called if you add if h.reading then uv.read_stop(h) end

soumith avatar Feb 02 '14 17:02 soumith

https://github.com/soumith/async/commit/0cbe855385d82040ee4282c38313b4385a10ec4a

soumith avatar Feb 02 '14 17:02 soumith