clemahieu

Results 15 comments of clemahieu

I'll take a look and see what I can do. Thanks again for making this library, this is much better than any other c++ http library I've used.

We should also have an affirmative test that shows the ip blocking works.

The concept for this PR makes sense and I agree it'd be useful to implementations. The websocket.confirmation_options test fails which needs to be addressed. This seems like a possible race...

Relevant RFC https://www.ietf.org/rfc/rfc2732.txt I think we should only use the square brackets in the same way it would be used for an ipv6 address in the browser i.e. they wouldn't...

Is there a reason to keep the signature when we don't have the content's that's been signed? We can't verify it against anything.