printing-tools-ng icon indicating copy to clipboard operation
printing-tools-ng copied to clipboard

Hamburger Menu

Open JPRuehmann opened this issue 1 year ago • 16 comments

Is there a Way to disable ore move the Entry at the end directly under the Close Entry of the Hamburger Menu?

JPRuehmann avatar Aug 08 '23 12:08 JPRuehmann

@JPRuehmann You are correct to ask, this is not the place for the item. There is a missing tools menu handling in the api. I am waiting for that as trying to hack it will cause problems. I may see about removing temporarily now that I have the button. @cleidigh

cleidigh avatar Aug 14 '23 20:08 cleidigh

I guess this problem also covers the position of the menu item in the standard menu bar? Right now it is the last item in the File menu and should be moved up if possible (so that Quit is at the bottom).

Przbl avatar Oct 06 '23 17:10 Przbl

@JPRuehmann @Przbl @DenB10 @kiki-ja @tidebre67 @RRoenn @KC-T @madvinegar @Jayonas

Quick poll: I am thinking of removing the print ng entry from the Hamburger menu. -It sits in the wrong place below Quit

  • There is not a system print there so why should we be there
  • We can print from many more appropriate places

Votes? @cleidigh

cleidigh avatar Oct 27 '23 16:10 cleidigh

I didn't even know there was an NG entry there. I agree to remove it. Wrong place and noone goes through the hamburger menu to print.

madvinegar avatar Oct 27 '23 16:10 madvinegar

I didn't even know there was an NG entry there. I agree to remove it. Wrong place and noone goes through the hamburger menu to print. Akrivos %-}

cleidigh avatar Oct 27 '23 17:10 cleidigh

@cleidigh never used PTNG from the Hamburger Menu. So nothing against to remove it there.

tidebre67 avatar Oct 27 '23 17:10 tidebre67

Thunderbird Supernova has reduced the two-row horizontal menu to one row leaving not enough space to accommodate so many buttons. The hamburger menu is not really useful for quick access. Putting PTNG at the bottom there is also not useful nor necessary. I only use Ctrl-P. I just removed PTNG from the horizontal menu. Two items for PTNG and its setting still exist at the "File" drop down menu. Fine to change as just mentioned.

Incidentally, when I click the default Print item there, PTNG format does not apply.. When I click the PTNG item, PTNG format applies. Both have the short cut key Ctrl-P, but the default Print is overridden by PTNG. I did not know this until now. No problem.

KC-T avatar Oct 27 '23 17:10 KC-T

@KC-T I am fixing the File menu as well.

  • moving Print NG and options under Print
  • Removing Ctrl-P from TB print
  • Shortcut still reassigned to ptng

@cleidigh

cleidigh avatar Oct 27 '23 17:10 cleidigh

Although I think that I noticed it in the hamburger menu at one point, I too never actually use that to print. I always use a toolbar button, either the main toolbar or whatever you call the smaller toolbar on the right side of the header area in the email reading view. I agree that the item doesn't really feel like it belongs in the hamburger menu, especially not way at the bottom, and I also agree that it generally makes the most sense for NG to appear in the same places that the built-in Print appears.

Jayonas avatar Oct 27 '23 18:10 Jayonas

@cleidigh

I agree to the removal with the condition that the PTNG toolbar icons and PTNG context menu remain as they are. The reasons are as follows.

  1. Thunderbird the Hamburger menu has Print by default.
  2. Users who use it can also choose to print by PTNG.
  3. On the other hand, the design of the Hamburger menu is complicated and it is difficult to add or change the position of the PTNG print menu. Note: The design specifications do not taken into account for customization by add-ons.
  4. Even if removed, access to PTNG printing is still provided via toolbar icons and context menus.

Other: Please do not remove the Ctrl+Shift+P (PTNG Option) and Ctrl+P (PTNG Print) shortcut key. However, Ctrl+P (PTNG Print) must be assigned to a new shortcut key.

Reason: Because it is convenient and I myself use it often. Ctrl+P (Thunderbird default) and Ctrl+P (PTNG Print) are convenient because it is possible to use them in different ways.

@kiki-ja

kiki-ja avatar Oct 28 '23 06:10 kiki-ja

@kiki-ja Ok I had not thought about creating a substitute shortcut for the native print.

This is currently not supported , only Control-P redirected to ptng.

Initially I thought we could change to a new shortcut, however, I had forgotten that I take over the internal shortcut such that the native one is controlled by ptng. It's actually a different mechanism that I don't have and for now would prefer not to try and mess with.

I think removing the incorrect native acceltext and adding the options one are good clarity improvements.

The hamburger entry is gone...

@cleidigh

cleidigh avatar Oct 28 '23 17:10 cleidigh

If we could remove the oem "print" option from the file menu, it would be perfect. :)

Some times I get confused and I press it instead of Print_NG.

1

madvinegar avatar Oct 30 '23 08:10 madvinegar

I disagree removing of Print… (Ctrl+P) from Thunderbird's default menu. The reasons are clear.

  1. Add-ons are functions to extend, not to remove the main functions.
  2. If you want to customize (remove or hide) Thunderbird's default menu, you should use userChrome.css or other add-ons.
  3. Thus, it is not the role of PrintingTools NG.

@kiki-ja

kiki-ja avatar Oct 30 '23 12:10 kiki-ja

I thought it was like that in previous versions. (i.e. in Print_NG v2.xx and in thunderbird v.102.x.x.

In these versions you only had the print_Ng option in the file menu.

Am I wrong...?

madvinegar avatar Oct 30 '23 12:10 madvinegar

I have been using Ctrl-P for Printing Tools NG and prefer retaining it to override the default Print, which can also be retained in the File menu in case people would like to use the default, which should not be very frequent to deserve two different short cut keys.

KC-T avatar Oct 30 '23 12:10 KC-T

@madvinegar You are correct in pre v115 versions the File entry for the native print was removed. Because of the new menu api I have not done any manipulation other than a couple of specific attributes. Besides that I also think per @kiki-ja comment that maintaining the native print is more appropriate so users can use it if desired.

It is not perfect, but we have to deal with compromises. What I really hate is the fact that extensions are forced to the bottom of the menus. @cleidigh

cleidigh avatar Oct 30 '23 16:10 cleidigh