printing-tools-ng icon indicating copy to clipboard operation
printing-tools-ng copied to clipboard

Some problems with v.2.2.3

Open RRoenn opened this issue 2 years ago • 4 comments

Hello @cleidigh,

today I tried with a fresh new tb version 102.12.0 (german) just installed PTNG. Here are some remarks

  1. in addon description is still version 2.1.1: ... 6. Mai 2022 option dialog is v2.2.3
  2. can't print attachment eml, I think this is issue https://github.com/cleidigh/printing-tools-ng/issues/126 nothing happens if I click print or print preview - There is no way for me to print this email. Even a restart brought no improvement.
  3. Border around header and header background color is set in ptng options with print or print preview border is visible but no background color is visible - option "print background" is checked in print preview. I have to uncheck and check option "print background" again, then, background color is visible. I read, that there was some changes with that option?
  4. is it possible to get a colored header without "print background"?

Thank you for your tireless work and best regards

/edit 5. if I open an .eml from drive with tb and try to print I get in the mail window every time a new line with the attachment title and size - but no print results at all

RRoenn avatar Jul 04 '23 15:07 RRoenn

@2 debug console

Uncaught (in promise) Exception { name: "NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED", message: "JavaScript component does not have a method named: "getProperty"'JavaScript component does not have a method named: "getProperty"' when calling method: [nsIMsgDBHdr::getProperty]", result: 2153185328, filename: "chrome://messenger/content/parent/ext-mail.js", lineNumber: 1753, columnNumber: 0, data: null, stack: "convertMessage@chrome://messenger/content/parent/ext-mail.js:1753:35\nconvert@chrome://messenger/content/parent/ext-mail.js:2224:12\ngetAttatchmentList@chrome://printingtoolsng/content/printingtoolsng-pengine.js:2174:63\naddAttTable@chrome://printingtoolsng/content/printingtoolsng-pengine.js:2185:37\nreformatLayout@chrome://printingtoolsng/content/printingtoolsng-pengine.js:1196:23\nPrintSelectedMessages@chrome://printingtoolsng/content/printingtoolsng-pengine.js:142:25\n", location: XPCWrappedNative_NoHelper } ​ columnNumber: 0 ​ data: null ​ filename: "chrome://messenger/content/parent/ext-mail.js" ​ lineNumber: 1753 ​ location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … } ​​ QueryInterface: function QueryInterface() ​​ asyncCaller: null ​​ asyncCause: null ​​ caller: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: , name: , … } ​​ columnNumber: 35 ​​ filename: "chrome://messenger/content/parent/ext-mail.js" ​​ formattedStack: "convertMessage@chrome://messenger/content/parent/ext-mail.js:1753:35\nconvert@chrome://messenger/content/parent/ext-mail.js:2224:12\ngetAttatchmentList@chrome://printingtoolsng/content/printingtoolsng-pengine.js:2174:63\naddAttTable@chrome://printingtoolsng/content/printingtoolsng-pengine.js:2185:37\nreformatLayout@chrome://printingtoolsng/content/printingtoolsng-pengine.js:1196:23\nPrintSelectedMessages@chrome://printingtoolsng/content/printingtoolsng-pengine.js:142:25\n" ​​ lineNumber: 1753 ​​ name: "convertMessage" ​​ nativeSavedFrame: SavedFrame { source: "chrome://messenger/content/parent/ext-mail.js", sourceId: 165, line: 1753, … } ​​ sourceId: 165 ​​ sourceLine: "" ​​ toString: function toString() ​​ <get asyncCaller()>: function asyncCaller() ​​ <get asyncCause()>: function asyncCause() ​​ <get caller()>: function caller() ​​ <get columnNumber()>: function columnNumber() ​​ <get filename()>: function filename() ​​ <get formattedStack()>: function formattedStack() ​​ <get lineNumber()>: function lineNumber() ​​ <get name()>: function name() ​​ <get nativeSavedFrame()>: function nativeSavedFrame() ​​ <get sourceId()>: function sourceId() ​​ <get sourceLine()>: function sourceLine() ​​ : Object { … } ​ message: "JavaScript component does not have a method named: "getProperty"'JavaScript component does not have a method named: "getProperty"' when calling method: [nsIMsgDBHdr::getProperty]" ​ name: "NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED" ​ result: 2153185328 ​ stack: "convertMessage@chrome://messenger/content/parent/ext-mail.js:1753:35\nconvert@chrome://messenger/content/parent/ext-mail.js:2224:12\ngetAttatchmentList@chrome://printingtoolsng/content/printingtoolsng-pengine.js:2174:63\naddAttTable@chrome://printingtoolsng/content/printingtoolsng-pengine.js:2185:37\nreformatLayout@chrome://printingtoolsng/content/printingtoolsng-pengine.js:1196:23\nPrintSelectedMessages@chrome://printingtoolsng/content/printingtoolsng-pengine.js:142:25\n" ​ : ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … } ​​ columnNumber: ​​ data: ​​ filename: ​​ lineNumber: ​​ location: ​​ message: ​​ name: ​​ result: ​​ stack: ​​ toString: function toString() ​​ Symbol(Symbol.toStringTag): "Exception" ​​ <get columnNumber()>: function columnNumber() ​​ <get data()>: function data() ​​ <get filename()>: function filename() ​​ <get lineNumber()>: function lineNumber() ​​ <get location()>: function location() ​​ <get message()>: function message() ​​ <get name()>: function name() ​​ <get result()>: function result() ​​ <get stack()>: function stack() ​​ <set stack()>: function stack() ​​ : Object { … } ​​​ defineGetter: function defineGetter() ​​​ defineSetter: function defineSetter() ​​​ lookupGetter: function lookupGetter() ​​​​ length: 1 ​​​​ name: "lookupGetter" ​​​​ : function () ​​​ lookupSetter: function lookupSetter() ​​​ proto: ​​​ constructor: function Object() ​​​ hasOwnProperty: function hasOwnProperty() ​​​ isPrototypeOf: function isPrototypeOf() ​​​ propertyIsEnumerable: function propertyIsEnumerable() ​​​ toLocaleString: function toLocaleString() ​​​ toSource: function toSource() ​​​ toString: function toString() ​​​ valueOf: function valueOf() ​​​ <get proto()>: function proto() ​​​ <set proto()>: function proto() ext-mail.js:1753

RRoenn avatar Jul 04 '23 15:07 RRoenn

@RRoenn Hope all is good. I have not yet tried to reproduce, but wanted to fire off a couple of questions... This is surprising because it had only two small patches that had nothing to do with the issues you mentioned. So first question, is this the only 2.2.3 install where you see this? Does a downgrade to 2.2.2 make the issue go away?

On the background header color: yes the Print Background Colors option in preview has to be set for any backgrounds to show for both headers and body. In 2.2.2 we made this preview option be automatically set if the user set a background color in PTNG options. The fact that you had to toggle says it was half set???

Will investigate, but rushing to release IETNG for 115. @cleidigh

cleidigh avatar Jul 05 '23 16:07 cleidigh

@RRoenn I cannot reproduce the background color issue, it behaves correctly for me on 2.2.2 and 2.2.3, see my questions above. Can you describe exactly the construction of a problem email? @cleidigh

cleidigh avatar Jul 07 '23 17:07 cleidigh

PTNG 2.2.3 Thunderbird 102.13.0 64bit Windows 10 Pro 22H2 64bit

@RRoenn @cleidigh

  1. in addon description is still version 2.1.1: ... 6. Mai 2022 option dialog is v2.2.3

As of July 15, 2023, the Add-on Manager descriptions is up to version 2.2.3, as shown below. Addon descriptions is linked to ATN (addons.thunderbird.net). Does it still not show up?

PTNG 2 2 3 on Addons-Manager 01

PTNG 2 2 3 on Addons-Manager 02

PTNG 2 2 3 on Addons-Manager 03

  1. can't print attachment eml, I think this is issue Printing mails forwarded as attachments #126 nothing happens if I click print or print preview - There is no way for me to print this email. Even a restart brought no improvement.

I am in the same boat. Currently there is a workaround to save the attached eml file locally, open it in Thunderbird and print it with PTNG v2.2.3.

but no background color is visible - option "print background" is checked in print preview.

I did not reproduce it.

  1. is it possible to get a colored header without "print background"?

It would be possible to have an additional option to turn the backgrounds color on or off separately for the headers and message body.

  1. if I open an .eml from drive with tb and try to print I get in the mail window every time a new line with the attachment title and size - but no print results at all

I did not reproduce it. Only the subject of the message was displayed in the title bar of the window.

eml open window

@kiki-ja

kiki-ja avatar Jul 16 '23 10:07 kiki-ja