fastkml icon indicating copy to clipboard operation
fastkml copied to clipboard

Increased precision of coordinates from 6 to 8 decimals

Open tenitz opened this issue 3 years ago • 3 comments

Fixes #67

tenitz avatar Mar 19 '21 11:03 tenitz

Hello @tenitz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 162:80: E501 line too long (81 > 79 characters)

pep8speaks avatar Mar 19 '21 11:03 pep8speaks

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 7.29 ⭐ 7.29 ⭐ 0.00
Method Length 65.10 🙂 65.10 🙂 0.00
Working memory 9.68 🙂 9.68 🙂 0.00
Quality 64.61% 🙂 64.61% 🙂 0.00%
Other metrics Before After Change
Lines 362 362 0
Changed files Quality Before Quality After Quality Change
fastkml/geometry.py 64.61% 🙂 64.61% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
fastkml/geometry.py Geometry._get_multigeometry 20 😞 213 ⛔ 11 😞 37.67% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
fastkml/geometry.py Geometry.etree_element 9 🙂 104 🙂 13 😞 54.47% 🙂 Extract out complex expressions
fastkml/geometry.py Geometry._get_geometry 4 ⭐ 129 😞 11 😞 59.41% 🙂 Try splitting into smaller methods. Extract out complex expressions
fastkml/geometry.py Geometry._etree_coordinates 6 ⭐ 81 🙂 11 😞 63.87% 🙂 Extract out complex expressions
fastkml/geometry.py Geometry.__init__ 4 ⭐ 63 🙂 13 😞 65.25% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai[bot] avatar Mar 19 '21 11:03 sourcery-ai[bot]

would probably be better if _etree_coordinates took an optional parameter precision.

cleder avatar Oct 01 '21 19:10 cleder