Refactor times.py

[cleder]

Refactor times to use the registry.

• Add new classes When, Begin and End
• Remove the etree_element and _get_kwargs methods from TimeStamp and TimeSpan
• Add new function following the GetKWArgs Protocol to parse the KmlDateTime from XML
• Add new function following the SetElement Protocol to create the etree representation
• Register the functions for the new classes
• TimeStamp to optionally take the above when
• TimeSpan to optionally take begin and end

[rishitc]

Hi @cleder, I'm interested in working on this issue. Can you please assign it to me?

Thanks

[cleder]

Thanks @rishitc

[rishitc]

Hi @cleder, I want to update you that I'm working on this. Progress is a bit slow, but I hope to have an initial patch soon.

Thanks

[cleder]

Can you document how to do it? For me, it is obvious, so I need an outsider's view on it to improve the documentation :wink:

[cleder]

BTW, make a draft pull request, ask questions, I am happy to provide some guidance

[rishitc]

Hi @cleder,

Can you document how to do it? For me, it is obvious, so I need an outsider's view on it to improve the documentation 😉

Sure, I can work more on that as part of the #343

BTW, make a draft pull request, ask questions, I am happy to provide some guidance

Thank you so much 😄 I'll put up my draft PR by Saturday 👍

[rishitc]

Hi @cleder, In the file fastkml/times.py, TimeSpan already optionally accepts a begin and end of type Optional[KmlDateTime], so I think that sub-task is already taken care of, correct?

[rishitc]

@cleder, also the new classes When, Begin, and End must derive from _TimePrimitive so that they can access the super()._get_kwargs and super().etree_element methods, correct?

[cleder]

I am not sure what you are trying to say, can you make a draft PR?

[rishitc]

Sounds good, I'll put up my draft PR in the next hour 👍

[rishitc]

Hi @cleder, My draft PR is up 🎉

---

Also, here's the current checklist status of my PR:

• [x] Add new classes When, Begin and End
• [x] Remove the etree_element and _get_kwargs methods from TimeStamp and TimeSpan
• [ ] Add new function following the GetKWArgs Protocol to parse the KmlDateTime from XML
  • The new classes will need to import from _TimePrimitive to support this, right?
• [ ] Add new function following the SetElement Protocol to create the etree representation
  • The new classes will need to import from _TimePrimitive to support this, right?
• [ ] Register the functions for the new classes
• [x] TimeStamp to optionally take the above when
• [x] TimeSpan to optionally take begin and end
  • I think this has already been completed in an older commit.

[rishitc]

Hi @cleder,

I took a look at the changes in https://github.com/cleder/fastkml/commit/6e4dba115107b403af88afe0fc073cfe6f52afdc and the changes look good 👍

I'll learn more about the codebase to work on issues faster next time.

Thanks for your patience and guidance as I worked through the issue.

Thanks