Add PhotoOverlay, Camera, LookAt, AbstractView support

[martimpassos]

Hi, still a bit of work to be done (and some useless functions I probably created in the heat of the moment), but I decided to open the PR to discuss a few points. Am comparing against main for easier merging, let me know if I should compare against develop instead. Fixes #102 Fixes #19

[pep8speaks]

Hello @martimpassos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file fastkml/kml.py:

Line 140:21: W503 line break before binary operator Line 153:17: W503 line break before binary operator

Comment last updated at 2022-04-19 19:57:29 UTC

[martimpassos]

Sorry, the refactoring PRs are annoying, is there anyway I can avoid them?

[ghost]

CodeSee Review Map:

Review in an interactive map

View more CodeSee Maps

Legend

[martimpassos]

hi @cleder, please take a look at this when you can. The module tests are all passing, but not the github actions ones. I'm not super used to contributing to other projects, hopefully I didn't embarrass myself too much. ImagePyramid and ViewVolume should probably become classes like Camera (I can make LatLonBox a class as well as per the TODO comment), just wanted to have a green light before going forward.

[martimpassos]

Hello @cleder, do you have feedback on this PR? Please let me know

[dericke]

Hey @martimpassos, it looks as though there are a couple of easy fixes suggested here. Making the suggested changes should clear up one of the checks that's currently failing.

[martimpassos]

Thanks @dericke, I have addressed the issues in the code I introduced. The remaining ones are present in the currently published version.

[sourcery-ai[bot]]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.45%.

Quality metrics	Before	After	Change
Complexity	2.42 ⭐	3.14 ⭐	0.72 👎
Method Length	61.12 🙂	54.99 ⭐	-6.13 👍
Working memory	6.17 ⭐	6.17 ⭐	0.00
Quality	76.35% ⭐	75.90% ⭐	-0.45% 👎

Other metrics	Before	After	Change
Lines	3504	4152	648

Changed files	Quality Before	Quality After	Quality Change
fastkml/kml.py	71.86% 🙂	72.05% 🙂	0.19% 👍
fastkml/test_main.py	78.94% ⭐	79.29% ⭐	0.35% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
fastkml/kml.py	_Feature.from_element	22 😞	437 ⛔	8 🙂	35.64% 😞	Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py	_Feature.etree_element	25 😞	332 ⛔	6 ⭐	40.21% 😞	Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py	PhotoOverlay.from_element	23 😞	267 ⛔	7 🙂	41.16% 😞	Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py	Placemark.from_element	7 ⭐	244 ⛔	10 😞	48.69% 😞	Try splitting into smaller methods. Extract out complex expressions
fastkml/kml.py	_TimePrimitive.parse_str	6 ⭐	146 😞	12 😞	53.78% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!