fastkml icon indicating copy to clipboard operation
fastkml copied to clipboard

Address Sourcery Code Quality Report recommendations

Open cleder opened this issue 4 years ago • 1 comments

Sourcery Code Quality Report

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
fastkml/kml.py _Feature.from_element 21 😞 395 ⛔ 8 🙂 36.79% 😞 Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py _Feature.etree_element 21 😞 287 ⛔ 7 🙂 41.68% 😞 Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py Placemark.from_element 7 ⭐ 241 ⛔ 10 😞 48.86% 😞 Try splitting into smaller methods. Extract out complex expressions
fastkml/kml.py _TimePrimitive.parse_str 6 ⭐ 146 😞 12 😞 53.78% 🙂 Try splitting into smaller methods. Extract out complex expressions
fastkml/kml.py KML.from_string 7 ⭐ 149 😞 9 🙂 58.19% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

cleder avatar Oct 01 '21 18:10 cleder

This looks a lot like: https://www.youtube.com/watch?v=8bZh5LMaSmE

cleder avatar Dec 24 '21 12:12 cleder