Overlays

[cleder]

[pep8speaks]

Hello @cleder! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-10-22 19:07:53 UTC

[cleder]

Quality gate: Passed

13 Issues

• 13 Code issues

Details

[sourcery-ai[bot]]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.37%.

Quality metrics	Before	After	Change
Complexity	3.16 ⭐	3.30 ⭐	0.14 👎
Method Length	64.01 🙂	63.95 🙂	-0.06 👍
Working memory	5.70 ⭐	5.73 ⭐	0.03 👎
Quality	75.84% ⭐	75.47% ⭐	-0.37% 👎

Other metrics	Before	After	Change
Lines	4115	4445	330

Changed files	Quality Before	Quality After	Quality Change
fastkml/kml.py	70.30% 🙂	70.26% 🙂	-0.04% 👎
fastkml/tests/kml_test.py	94.18% ⭐	85.11% ⭐	-9.07% 👎
fastkml/tests/oldunit_test.py	80.84% ⭐	80.58% ⭐	-0.26% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
fastkml/kml.py	_Feature.from_element	22 😞	517 ⛔	8 🙂	35.14% 😞	Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py	_Feature.etree_element	25 😞	431 ⛔	7 🙂	36.15% 😞	Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py	PhotoOverlay.from_element	23 😞	324 ⛔	7 🙂	39.18% 😞	Refactor to reduce nesting. Try splitting into smaller methods
fastkml/kml.py	Placemark.from_element	7 ⭐	298 ⛔	9 🙂	48.44% 😞	Try splitting into smaller methods
fastkml/kml.py	Camera.etree_element	8 ⭐	226 ⛔	9 🙂	50.84% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[ghost]

👇 Click on the image for a new way to code review

• Make big changes easier — review code in small groups of related files

• Know where to start — see the whole change at a glance

• Take a code tour — explore the change with an interactive tour

• Make comments and review — all fully sync’ed with github

  Try it now!

Legend

[codecov[bot]]

Codecov Report

Merging #123 (89403cc) into develop (ffb9a3c) will decrease coverage by 0.38%. The diff coverage is 84.65%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
- Coverage    89.20%   88.82%   -0.39%     
===========================================
  Files           19       19              
  Lines         4113     4285     +172     
===========================================
+ Hits          3669     3806     +137     
- Misses         444      479      +35