clr-installer icon indicating copy to clipboard operation
clr-installer copied to clipboard

clr-installer fails when trying to do a clean install on an old ZFS partition

Open omkhar opened this issue 5 years ago • 9 comments

Describe the bug I attempted to install Clear Linux desktop over an old Ubuntu which used ZFS. ISO used: clear-33590-live-desktop

To Reproduce Steps to reproduce the behavior:

  1. Install Ubuntu 20.04, select ZFS
  2. dd clear-33590-live-desktop.iso to USB stick
  3. Boot into Clear Linux
  4. Launch installer, select "Destructive install"
  5. Installer dies right after trying to partition

Expected behavior 6. Installer should proceed. If you used wipefs on the partition first, installer proceeds fine. Presumably the installer dies when it sees a ZFS signature on the partition.

Environment (please complete the following information):

  • Clear Linux OS Version: clear-33590-live-desktop.iso

omkhar avatar Sep 06 '20 16:09 omkhar

Destructive install should replace the disk partition table, so we shouldn't see the previous ZFS. Haven't had an opportunity to wipe a drive and test this yet; need to reproduce to get the /root/clear-installer.log file.

mdhorn avatar Oct 05 '20 23:10 mdhorn

ZFS actually peppers some signature/magic throughout the block device, simply clearing the partition table won't be enough, if the partitioning tool is smart enough to read it. I'm building a VM to test and provide a clear-installer.log as requested.

omkhar avatar Jan 03 '21 19:01 omkhar

Here's both the Ubuntu installer as well as a log of the Clear Linux install failing. bug-753-logs.zip

omkhar avatar Jan 03 '21 20:01 omkhar

Here is what wipes reports as being present on /dev/sda (block device for clear install)

wipefs.txt

omkhar avatar Jan 03 '21 20:01 omkhar

my guess is that https://github.com/clearlinux/clr-installer/blob/master/storage/block_devices_ops.go needs to be amended to run wipefs -a during a destructive install against partitions before laying down the filesystem

omkhar avatar Jan 03 '21 20:01 omkhar

image

results of running wipefs -a

omkhar avatar Jan 03 '21 20:01 omkhar

This time I had to run dd if=/dev/zero of=/dev/sda bs=1G before the installer would work. wipefs -a was not enough.

omkhar avatar Jan 03 '21 21:01 omkhar

@omkhar Thanks for the follow up. I'm surprised wipefs doesn't clear the file system information; that's is how we prep for an encrypted installed.

mdhorn avatar Jan 04 '21 17:01 mdhorn

quite easy to reproduce, please let me know if you require further artifacts?

omkhar avatar Jan 04 '21 17:01 omkhar