cloud-native-setup icon indicating copy to clipboard operation
cloud-native-setup copied to clipboard

Fix partly #225.

Open marcemq opened this issue 6 years ago • 3 comments

What Generate a final report for k8s-scaling.json result in different subdirectories which follows the current hard-coded test name k8s-scaling.

Edited files:

  • report/report_dockerfile/tidy_scaling.R
  • report/report_dockerfile/dut-details.R

Testing done: Having the next results structure:

$ tree results/
results/
├── Env.R
├── scaling
│   └── k8s-scaling.json
└── scaling2
    └── k8s-scaling2.json

2 directories, 3 files

the k8s-scaling2.json does not follow the hard-coded test name, and only for it a warning message will be displayed in the final report, see report attached. metrics_report.pdf

marcemq avatar Oct 18 '19 21:10 marcemq

Ah, I meant to leave notes on the PR here, but left them on the Issue #225 instead - please take a look @marcemq

grahamwhaley avatar Oct 31 '19 10:10 grahamwhaley

ping @marcemq - did you see the notes on #225 ? Make sense? whilst here, I notice this PR and commit subject names are not very descriptive (Fix partly #225. ). Can you make it a meaningful short sentence. Have a look at the repo history for examples (git log --oneline for instance). thanks!

Note, btw, I see you did add a comprehensive set of info to the PR body - that afaik does not make it into the git log history itself - sometimes it is better to add, or duplicate, that information in the commit bodies, as that does make it into git.

grahamwhaley avatar Nov 12 '19 19:11 grahamwhaley

@grahamwhaley I'll consider your comments about PR and git meaningful short sentence.

In terms of this fix and your comments at #225, I think we need to define a configurable report, so it works with this edge cases and the behaviour of the report phase is clearer and well define, I haven't had a chance to write it formally because right know I'm focusing on scale the test at #248.

marcemq avatar Nov 13 '19 18:11 marcemq