runtime
runtime copied to clipboard
clearcontainers
WIP: Debug: Enable VM debug console
Enable the VM debug console whenever the VM Kernel debug is enabled.
Fixes: #559.
Has a dependency on having a updated agent being installed in the container rootfs to add the new systemd services.
https://github.com/clearcontainers/agent/pull/122
Signed-off-by: Manohar Castelino [email protected]
CI is failing though. I suspect we probably have a vendor or merge dep? In f26 we have:
../../../go/src/github.com/clearcontainers/runtime/list.go:84: undefined: defaultRootDirectory
../../../go/src/github.com/clearcontainers/runtime/main.go:91: undefined: defaultRootDirectory
../../../go/src/github.com/clearcontainers/runtime/config.go:146: too many errors
Hmm, actually the CI run was successful for all 3 runs. Looks like there might be an issue with the jenkins-github plugin @sboeuf ?
@grahamwhaley - the undefined errors are caused by the jenkins scripts incorrectly go get'ing the runtime code (it should be go get -d). Hopefully we can resolve that once https://github.com/clearcontainers/jenkins/issues/10 lands.
Hi @mcastelino - this requires an update to the tests. From the CI logs:
./create_test.go:848: cannot use func literal (type func(string) []virtcontainers.Param) as type func(string, oci.RuntimeConfig) []virtcontainers.Param in assignment
Hi @mcastelino - just one final nit in the docs from me.
@iphutch - please could you review the doc changes?
Hi @klynnrif, @rcaballeromx - I'm assuming @iphutch won't be able to complete this review so could one of you take a look and if you're happy, we'll force-merge this as we will have the requisite doc team approval.
@jodh-intel @rcaballeromx the suggestions @iphutch made lgtm. All good to me with those changes. Thanks!
