clean99
clean99
@afc163 @zombieJ @MadCcc Hi大佬们,请问有时间可以帮我看看这个pr吗?我还想继续帮忙写测试但是怕写得不好。。
> Hi @clean99, could you please provide link to repo with failed CI? Hi @rodion-arr, thanks for replying to me, you can check this [git actions](https://github.com/nodejs/nodejs.dev/runs/6287635678?check_suite_focus=true) and [commit](https://github.com/nodejs/nodejs.dev/pull/2436/commits/49fbaf3fcc3fbe5e7cd8991a9df8c79948b15ae6)(and previously commits)...
> I assume it's related to #2092 - linter checks JS code blocks in markdown that was changed in your branch, not sure why they wasn't listed in original PR...
> 那个快照为什么删了呀? 这个快照在这里是验证 `ConfigProvider.Form form requiredMark set requiredMark optional 1`, 我理解就是验证`requiredMark`可以设置表单Item的类为`'ant-form-item-required-mark-optional'`,我认为可以用更直白的assert来说明这件事:`expect(screen.getByTitle('年龄')).toHaveClass('ant-form-item-required-mark-optional');` Snapshot测试有不少缺点,我在另外一个pr里面有简单提到过#36926, 具体到这个snapshot主要有几点: * snapshot测试是没有重点的,可读性很差,非常难理解snapshot想表达什么。不像上面的那个,读者一看就知道expect的是什么。 * snapshot测试锁死了很多跟这个测试用例没关系的dom结构、class等,假如其他class改动,这个测试也会失败,也就是false negative
目前只有config provider的测试,会在这个分支补充上form组件的测试。
I will do this in the weekend.
Before supporting PDF upload, multi-image upload should be supported given that PDF typically contains more than one image.
> When I messed around with ChatGPT, it hallucinated a lot when it did a visual comparison. I'm curious if your prompt works well. How are the visual comparison results?...