integration icon indicating copy to clipboard operation
integration copied to clipboard
verified publisher icon clbustos

Total library rewrite

Open arrowcircle opened this issue 11 years ago • 7 comments

Total library rewrite. Main goals are compatibility with latest Ruby (2.1.2), total architecture remake and old API compatibility.

  1. Extracted and refactored each ruby integration method to separate class.
  2. Rewritten GSL and Ruby wrappers for integrate method.
  3. Rewritten specs to support new syntax. Cleared specs.
  4. Updated Readme to markdown, added instruction for GSL usage (rb-gsl is now runtime dependency)
  5. Added bundler support (Added Gemfile)
  6. Made gem with bundle gem command (for simple rake release)
  7. Added travis-ci

arrowcircle avatar Jun 15 '14 15:06 arrowcircle

Hey @clbustos, what do you think? I haven't tested it locally, but these changes seems very good. Ideally, we should send them directly to Sciruby's integration fork.

@arrowcircle thanks for the PR! :)

agarie avatar Jun 19 '14 19:06 agarie

If doesn't broke any dependent library, fine with me. El jun 19, 2014 3:00 p.m., "Carlos Agarie" [email protected] escribió:

Hey @clbustos https://github.com/clbustos, what do you think? I haven't tested it locally, but these changes seems very good. Ideally, we should send them directly to Sciruby's integration fork https://github.com/SciRuby/integration.

@arrowcircle https://github.com/arrowcircle thanks for the PR! :)

— Reply to this email directly or view it on GitHub https://github.com/clbustos/integration/pull/3#issuecomment-46602471.

clbustos avatar Jun 19 '14 19:06 clbustos

@clbustos, @agarie any updates?

arrowcircle avatar Jul 07 '14 19:07 arrowcircle

I finally got some time to read through all the changes.

@clbustos: I think it's good to merge! We should send this to SciRuby/integration (and make it the default repository...) as well.

agarie avatar Jul 16 '14 16:07 agarie

Sorry for the delay. After guys from GSoC 2014 finish, we will rewrite according to your specs.

clbustos avatar Aug 09 '14 05:08 clbustos

Hey, whats going on? GSoC people making small changes, that I already made (bundler, rspec, travis, markdown), but my pull request is hanging for 2 months. Now, my work is useless, because its impossible to merge changes from the master branch. Thanks :(

arrowcircle avatar Aug 09 '14 13:08 arrowcircle

Hey, don't we mad. I will check eveything to merge all worth of it. El ago 9, 2014 9:14 a.m., "Oleg Bovykin" [email protected] escribió:

Hey, whats going on? GSoC people making small changes, that I already made (bundler, rspec, travis, markdown), but my pull request is hanging for 2 months. Now, my work is useless, because its impossible to merge changes from the master branch. Thanks :(

— Reply to this email directly or view it on GitHub https://github.com/clbustos/integration/pull/3#issuecomment-51686249.

clbustos avatar Aug 09 '14 13:08 clbustos