webkitfltk icon indicating copy to clipboard operation
webkitfltk copied to clipboard

aarch64 build fails with dom/Document.cpp:4226:5: error: expected ';' before 'if'

Open juanitotc opened this issue 5 years ago • 2 comments

compiling natively on RPi aarch64, build fails with:

make -C Source/WebCore CXX="g++ -march=armv8-a+crc -mtune=cortex-a72 -Os -pipe -DNDEBUG"
...
dom/Document.cpp:4226:5: error: expected ';' before 'if'
dom/Document.cpp:4231:9: error: expected ';' before 'if'
dom/Document.cpp:4293:9: error: expected ';' before 'if'

This seems to be fixed with this patch:

--- Source/WebCore/dom/Document.cpp.orig	2020-11-19 14:44:20.091862970 +0100
+++ Source/WebCore/dom/Document.cpp	2020-11-19 14:46:24.347862896 +0100
@@ -4222,12 +4222,12 @@
     unsigned i = 0;
 
     UChar32 c;
-    U16_NEXT(characters, i, length, c)
+    U16_NEXT(characters, i, length, c);
     if (!isValidNameStart(c))
         return false;
 
     while (i < length) {
-        U16_NEXT(characters, i, length, c)
+        U16_NEXT(characters, i, length, c);
         if (!isValidNamePart(c))
             return false;
     }
@@ -4289,7 +4289,7 @@
 
     for (unsigned i = 0; i < length;) {
         UChar32 c;
-        U16_NEXT(qualifiedName, i, length, c)
+        U16_NEXT(qualifiedName, i, length, c);
         if (c == ':') {
             if (sawColon) {
                 ec = NAMESPACE_ERR;

juanitotc avatar Nov 20 '20 09:11 juanitotc

Yeah, the ICU version you use has changed some things.

clbr avatar Nov 20 '20 10:11 clbr

It seems icu-62 is OK, but the patch is needed for icu-67.

juanitotc avatar Nov 20 '20 15:11 juanitotc