fifth
fifth copied to clipboard
clbr
dashed and dotted are broken
I use fifth-0.5 and webkitfltk-0.5.1. Both borders below are broken. Which file in webkitfltk-0.5.1 draws border lines resp. border styles?
winfried
| 10px red dashed | |
|---|---|
| Column 1 | Column 2 |
| Aaa Aaa Aaa | Xxx Xxx Xxx |
| Bbb Bbb Bbb | Yyy Yyy Yyy |
| Ccc Ccc Ccc | Zzz Zzz Zzz |
| 10px blue dotted | |
|---|---|
| Column 1 | Column 2 |
| Aaa Aaa Aaa | Xxx Xxx Xxx |
| Bbb Bbb Bbb | Yyy Yyy Yyy |
| Ccc Ccc Ccc | Zzz Zzz Zzz |
Rendered result: http://imgur.com/tSfiu5h
This is handled entirely by the common webkit code, and so should either affect all webkit browsers or all webkit browsers using cairo. I can't tell offhand which files are involved.
I compiled webkitgtk-2.13.4 and found that 'bin/MiniBrowser' does show the borders correctly.
Now I compiled 'surf2' using webkitgtk. It dows show the borders correctly.
Both programs are assumed to use CAIRO.
winfried
@clbr, how does this look like? I have changed the file
Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
winfried
This looks like a partial backport with different function name, etc. It would cause code conflicts the next time I sync against upstream webkit.
If it's indeed solved in current webkit, then I'd prefer for larger things like this to happen with the sync. If you need a source with that patch, I'd advise you to make a fork here on github. I can't give a date for when I can do the update, as it takes all day, not sure when I have that much free.
@clbr , I do not understand your objections.
The library compiles without error, the result is OK. What do you want more?
winfried
It also has to not make maintenance difficult, ie increase my workload too much.