Clay John

Results 587 comments of Clay John

Thank you! And congratulations on your first merged contribution! :tada: :partying_face:

Can you separate the bug fixes into a seperate PR? We like to keep new features separate from bug fixes so we can merge the bug fixes as efficiently as...

> If I raise a new PR for that please can you promise me you will help me get this PR closed? I can't promise much. I can continue giving...

@dalexeev Is the issue you mention a blocking issue for merging this PR or something that should be handled separately?

What changes did you make to the project? Just a quick look and I can see it is leaking 3 uniform sets per frame here: https://github.com/godotengine/godot-demo-projects/blob/6adcbc912e20ac163d9e7d37446ba189cb4a81b6/compute/texture/water_plane/water_plane.gd#L152 Looking around it seems...

This is changing code that hasn't changed in 3 years. And the error has been around since switch statements were added 6 years ago (in https://github.com/godotengine/godot/pull/31596). Therefore, I don't think...

> > This is changing code that hasn't changed in 3 years. And the error has been around since switch statements were added 6 years ago (in #31596). Therefore, I...

This reminds me of https://github.com/godotengine/godot/issues/90459 which we traced to a specific Adreno driver bug. Maybe the GE8320 has a similar bug.

I think that is expected with such a low end device. We need to implement CPU skinning (which is what we use for GLES2 in 3.6) to get comparable speed.

Can you check your driver settings and ensure that there are is no contrast boosting / sharpening setting? I had a similar issue a few years ago (but with an...