Clay John comments

Results 411 comments of


                                            Clay John

trafficstars

reflection probe resoloution never changes despite changing the reflection atlas if reflection probe is in UPDATE_ALWAYS mode

> I am getting a smooth 60 fps, 1080p using 2046 res reflections on a moving car when its set update_one That is promising! I'd suggest using that for now...

Add `rand_bool(true_chance)` function

This looks well done, but I'm not sure if it's something we need to have in core. I appreciate the benefit of having this auto complete when you just want...

[Android] Splash screen doesn't render with the `compatibility` renderer

Is this a new issue with beta 1? Have you reproduced this on earlier dev builds?

[Android] Splash screen doesn't render with the `compatibility` renderer

Testing master (292e50e17e3f6e2509d3178a00204f964a907460) on a pixel4 and I get the same splash screen with the compatibility renderer and with the mobile renderer. In both cases it is wrong, but it...

Improve shader function descriptions

That was unbelievably fast. I'm going to need a few days to review this. But I am very excited!

Improve shader function descriptions

I keep meaning to do a deep review of this. But this is a huge chunk of work and I never have the time to do it in one sitting....

Add smoothstep graphs

That makes sense. Merging now to be safe

Improve Description of gdshader SmoothStep and Mix functions

I think adding the full descriptions from the original GLSL docs is a good idea. The functions just pass through to the raw GLSL, so the official docs apply perfectly....

Improve Description of gdshader SmoothStep and Mix functions

> Oh, that's pretty sweet. If I do a bunch of copy-paste can I just pass you the file to put in your pull request? Sure! > Any complaints if...

Implement bicubic sampling for lightmaps

> > Indeed, this was a remnant of GLES2 support in 3.x. I think 3.x GLES3 used `textureSize()` too. > > 3.x GLES3 still used the same method as GLES2...