react.backbone icon indicating copy to clipboard operation
react.backbone copied to clipboard

Remove unused/undocumented component.onModelChange

Open tsjoberg opened this issue 9 years ago • 3 comments

tsjoberg avatar May 20 '15 05:05 tsjoberg

@markijbema @clayallsopp not sure what you envision for deprecation warning console.warn ? Or actually want me to check for implementation of onModelChange and call forceUpdate instead with console warning?

tsjoberg avatar May 20 '15 05:05 tsjoberg

Fixes https://github.com/clayallsopp/react.backbone/issues/40

tsjoberg avatar May 20 '15 05:05 tsjoberg

Yes, I think that would be best, and then remove it in a version a few months later. I'm not sure what react itself uses, but it seems to have some deprecation warning messaging, maybe you could plug into that?

Problem with just removing is that if somebody uses it, it may fail very subtly. For instance if you do increment of a counter, and then forceUpdate, the counter won't update, but everything seems to work, so this might silently introduce bugs.

markijbema avatar May 20 '15 06:05 markijbema