riemann icon indicating copy to clipboard operation
riemann copied to clipboard

multilayer SW solver requires dgesv

Open rjleveque opened this issue 7 years ago • 5 comments
trafficstars

Running nose tests on a new AWS EC2 instance revealed this issue in rpn2_layered_shallow_water.f90

lapack is required or at least the subroutine dgesv and any dependencies:

https://github.com/clawpack/riemann/blob/3d89c52f0c6ae6ed4e5ac3102b457b1931a8b592/src/rpn2_layered_shallow_water.f90#L103

rjleveque avatar Nov 20 '18 17:11 rjleveque

Are you thinking we should fall-back to directly compiled source for the routine? We definitely do not want to usually do this.

mandli avatar Nov 20 '18 22:11 mandli

Yes, best to use lapack if available. But we could provide something like we do for this example: https://github.com/clawpack/apps/blob/master/fvmbook/chap17/advdiff/tridiag.f

rjleveque avatar Nov 21 '18 00:11 rjleveque

So we would need to come up with some sort of check to see if we can link against a native LAPACK. Obviously a configure could do this so we probably need to come up with something similar.

mandli avatar Nov 21 '18 18:11 mandli

Or should we just cleanly skip this unit test if lapack isn't available, as happens with the netCDF tests?

rjleveque avatar Nov 26 '18 06:11 rjleveque

Might be easiest.

mandli avatar Nov 26 '18 19:11 mandli