pyclaw icon indicating copy to clipboard operation
pyclaw copied to clipboard

Inconsistent Names in `fort.t` File

Open mandli opened this issue 8 years ago • 2 comments

I noticed while adding another file format that the ascii routines write out nstates in place of ngrids and loops over states rather than patches. This clearly works ok but I think this confuses the role of states and patches in the code but before changing it I wanted to get some feedback as to what was intended with the number of states here. Are there plans to record the states at some point as well as patches for SharpClaw?

mandli avatar Nov 05 '16 22:11 mandli

No concrete plans. Of course, if we ever use multiple states per patch we'll need to update all the output routines to handle that. It's probably best to change this routine to be consistent with the others as you suggest.

ketch avatar Nov 07 '16 10:11 ketch

Ok, I will write up a PR.

mandli avatar Nov 07 '16 19:11 mandli