pyclaw icon indicating copy to clipboard operation
pyclaw copied to clipboard

Coveralls does not correctly measure coverage of examples/*.

Open ketch opened this issue 10 years ago • 3 comments

This seems to be caused by our use of symlinking for the examples directory. When I run the tests locally, the initial coverage report correctly gets the examples. But if I generate an html report (with coverage html) then the examples directory is omitted completely.

Coveralls is including the examples directory but reporting as if we didn't run any of it. This causes overall coverage to be drastically underreported.

One option would be to just move the examples directory down into pyclaw/src/pyclaw/. Or to move everything else up into clawpack/pyclaw.

ketch avatar May 08 '15 06:05 ketch

Sorry, I was on my mobile all yesterday. I am just trying to understand what you mean by your options above, namely what context would are you suggesting moving the examples directory. I have not really dealt much with cover-alls so that might be part of the problem.

mandli avatar May 09 '15 13:05 mandli

I am suggesting revising the directory structure so that coveralls can correctly detect our test coverage. I think that less tricky symlinking would be beneficial anyway.

ketch avatar May 10 '15 03:05 ketch

So for in-place installations we would create a symlink down into the package or just get rid of the top-level directory all-together?

mandli avatar May 10 '15 16:05 mandli