pyclaw icon indicating copy to clipboard operation
pyclaw copied to clipboard

Published 20 hours ago • verified publisher icon clawpack

Polynomial reconstruction in SharpClaw

Open sanromd opened this issue 10 years ago • 11 comments

This PR adds a routine for polynomial based reconstruction in SharpClaw. In detail,

  • 4th and 6th order Polynomial reconstrcution
  • 8th and 10th order reconstruction are also included but have not been fully tested yet
  • renames "weno_order" to "reconstruction_order"
  • deallocate calls for WENO5 and Poly_comp
  • sets number of ghost cells for either Weno or Poly in solver
  • documentation

sanromd avatar Dec 28 '14 11:12 sanromd

Just a reminder for anybody testing this -- you'll need to rebuild:

cd clawpack
pip install -e .

ketch avatar Dec 30 '14 09:12 ketch

I just merged in the fix for the doctests (from master) so this is passing now.

ketch avatar Dec 30 '14 10:12 ketch

This looks great and will be very useful. It would of course be nice to have:

  • A test that uses the new reconstruction
  • At least some comments at the top of poly.f90 documenting the functions there.

ketch avatar Dec 30 '14 10:12 ketch

Coverage Status

Coverage remained the same when pulling 5f6ee25b285f30be91df4c243cf9deb267722004 on sanromd:dev-poly into e20a78700e14207eaed809c312c9eb823529a856 on clawpack:master.

coveralls avatar Dec 30 '14 10:12 coveralls

@ketch working on

  • acoustics_1d test
  • comments on poly
  • documentation on solver

sanromd avatar Dec 30 '14 15:12 sanromd

What's the status of this PR?

mandli avatar Oct 24 '15 14:10 mandli

I made some modifications to it in my fork and rebased it... I haven't got time to finalize testing. I will update it soon.

On Saturday, October 24, 2015, Kyle Mandli [email protected] wrote:

What's the status of this PR?

— Reply to this email directly or view it on GitHub https://github.com/clawpack/pyclaw/pull/492#issuecomment-150820494.

Damián

ubi dubium ibi libertas

sanromd avatar Oct 24 '15 20:10 sanromd

Thanks for the update. Would you like this included in the 5.3.1 release or would this be better for the 5.4.0 release?

mandli avatar Oct 24 '15 23:10 mandli

If @sanromd can add a test or two soon, it would be great to get this into 5.4.0. It probably shouldn't go into 5.3.1 since it's a major feature and 5.4 is coming very soon anyway.

ketch avatar Oct 25 '15 14:10 ketch

Coverage Status

Changes Unknown when pulling 458933d196ff1dd9669273fd7b42ead224215b31 on sanromd:dev-poly into * on clawpack:master*.

coveralls avatar Mar 18 '16 10:03 coveralls

Coverage Status

Coverage decreased (-0.01%) to 69.671% when pulling c0095d24eace2d7fc04c689f02c377b64e653364 on sanromd:dev-poly into 314fd93dae8436a7238610f3c32bd86d665869f1 on clawpack:master.

coveralls avatar Oct 05 '16 09:10 coveralls