geoclaw
geoclaw copied to clipboard
clawpack
Sort out what can change when doing a restart
As mentioned in https://github.com/clawpack/geoclaw/pull/434, adding support for Lagrangian gauges (particle tracking) required doing some things in a different order for a restart.
More generally we should figure out what things are allowed to change when doing a restart (e.g. one can add new gauges but not remove old ones, can add additional levels but not have fewer) and make sure things are called in the right order between what is read in from the checkpoint file and what is set by reading a .data file, and better document all this.
I was looking at the restart code to see why the number of levels was not allowed to decrease, only increase.
Turns out there is an old comment line that says that, but the code actually allowed both.
I guess the comment should be updated. :)
— Marsha
On Feb 23, 2020, at 4:43 PM, Randall J. LeVeque [email protected] wrote:
As mentioned in #434 https://github.com/clawpack/geoclaw/pull/434, adding support for Lagrangian gauges (particle tracking) required doing some things in a different order for a restart.
More generally we should figure out what things are allowed to change when doing a restart (e.g. one can add new gauges but not remove old ones, can add additional levels but not have fewer) and make sure things are called in the right order between what is read in from the checkpoint file and what is set by reading a .data file, and better document all this.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/clawpack/geoclaw/issues/435?email_source=notifications&email_token=AAGUGC4VEGH4NO4GZYNJAS3RELUYBA5CNFSM4KZ6B7HKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPS3HXA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUGC2RQ5WB65DEDJC4NFDRELUYBANCNFSM4KZ6B7HA.
Yes, I guess we should update the comment, also in amrclaw. So I guess we just throw away the finer level data if restarting with fewer levels. Good to know.