Boundary condition bug shows up with inflow BCs

[rjleveque]

A bug apparently introduced when filpatch was made fully recursive, but hasn't shown up on our standard test suite. It shows up e.g. with inflow boundary conditions for 2d advection. The problem is that filpatch needs to fill small patches of ghost cells but the entire grid is passed in to bc2amr.

@mjberger is working on it. We may need to change the calling sequence of bc2amr.

[rjleveque]

@mjberger asked "is there ever a reason to have the level parameter (level of refinement of a grid) in the bc2amr routines? While I'm sorting through millions of arguments, it seems we don't use that one. I'm wondering why it's there."

It's not used in any of the standard BCs implemented in the library routine but I guess we thought a user might need it. Offhand I'm not sure why it might be needed -- I can't think of an example. Since hx and hy are passed in, the level could be deduced with a bit of work if it were needed, so I'd say we could probably drop it.

[rjleveque]

On further reflection we decided to leave the calling sequences alone.