Claus Wilke
Claus Wilke
No worries, I didn't feel singled out. In fact, I was surprised by my own comment from 2019 as today I don't think I would write it. (I came here...
I don't think that's a feasible approach. We want to be able to make plots such as these: ``` r library(ggplot2) world
I definitely don't like adding the `layer_param` as attribute to the data. The data gets handed back and forth to numerous functions, many of which get overwritten by extension packages,...
I think we need to be systematic and enumerate all the places where possibly layer parameters could be needed. I believe it's going to be geoms, facets, and stats. We...
However, all these objects are stateless, so I'm afraid we'd have to drill down to specific methods that will require layer_param.
I think this is a good idea. I very much adhere to the philosophy that we should optimize the API so we don't usually have to provide the dataset more...
I just saw that there is already some existing text on this topic. I may take a stab editing it along the lines of this issue.
@thomasp85 Regarding my point 2 above, I suggest something like the following to explain the issue. The main goal for theme developers should be to write themes that behave similarly...
I'm happy to tackle this. Honestly it's not lot of work. Mostly the chapter is in a good state. Issue #171 requires more work, but I'm happy to tackle that...
@thomasp85 Sure, that works also.