react-dat-gui icon indicating copy to clipboard operation
react-dat-gui copied to clipboard

Published 20 hours ago • verified publisher icon claus

Remove deep merge in update

Open disambiguator opened this issue 4 years ago • 3 comments

disambiguator avatar May 07 '20 06:05 disambiguator

Builds are failing here. I'd also appreciate it if you could add tests to cover functionality impacted by this change to assert that behaviour is identical before and after.

rohan-deshpande avatar May 14 '20 00:05 rohan-deshpande

Hey @rohan-deshpande. Absolutely. I fixed the build, seemed to be failing because of linting, which makes total sense. I just whipped up that change quickly. :)

In terms of tests, I'm not exactly sure what test coverage to add, since from my reading of the code, the change I made should affect all update code and should be covered in all existing update paths. If you have an idea of a test pathway to add, I'm happy to do that.

Does the overall idea of my change make sense? Is there something I'm missing in my understand that required the cloneDeep?

disambiguator avatar May 16 '20 21:05 disambiguator

@rohan-deshpande Any thoughts on merging this?

disambiguator avatar Oct 13 '20 06:10 disambiguator