cron-editor icon indicating copy to clipboard operation
cron-editor copied to clipboard

Upgrade Bootstrap lib to v4+

Open claudiuconstantin opened this issue 6 years ago • 5 comments

Upgrade bootstrap npm package to latest version

claudiuconstantin avatar Nov 19 '18 20:11 claudiuconstantin

Until this happens... is there any workaround to using this in a Bootstrap 4 application? The display is mangled for me and I can't figure out how to fix without conflicting with Bootstrap 4.

andrewryan1906 avatar Dec 19 '18 00:12 andrewryan1906

You need to override some css classes used in the library. I think the easiest method is to import the Bootstrap 3.x css file provided by the v3 npm package in your specific component. This is ugly, I know.

claudiuconstantin avatar Dec 19 '18 08:12 claudiuconstantin

But... if that component is using v4, won't they conflict?

I can hold off on this if you're planning on migrating in the next 30-60 days... do you have a timeline by any chance?

Andrew

andrewryan1906 avatar Dec 19 '18 11:12 andrewryan1906

Shouldn't conflict if you're creating a wrapper component just for the cron-editor and import (or maybe copy-paste?) v3 css file into that single component.

Unfortunately I don't have a timeline for v4 upgrade.

claudiuconstantin avatar Dec 19 '18 11:12 claudiuconstantin

I see there is a Pull Request for the upgrade for Bootstrap 4. Any timeline when this can get implemented?

bandman0226 avatar Mar 04 '21 20:03 bandman0226