Claudiu Belu
Claudiu Belu
/sig testing
> @claudiubelu can we make a new PR w/ just the log rotation fixes and try and get that merged into v1.25? Done: https://github.com/kubernetes/kubernetes/pull/111549
/milestone v1.26
/assign @dchen1107 @jingxu97 @kubernetes/sig-scheduling @kubernetes/sig-storage-pr-reviews
> this PR changes code logic as well. I'd suggest to retitle this PR to clarify it. > > Also PR has unanswered comment from @endocrimes, can you please address...
/test pull-kubernetes-e2e-capz-windows-containerd /assign @damemi @saad-ali
> This is very hacky. Is there an open issue in golang or wherever it's appropriate? > > We should at least put a TODO to remove this hack once...
> I mean `time.Since` I've added a reference to https://github.com/golang/go/issues/8687 in ``SinceInSeconds`` function. The Windows clock resolution is a known issue, and it's not an easy thing to change, as...
/test pull-kubernetes-e2e-capz-windows-containerd
> I mean `time.Since` Any other blockers for this PR?