Claudiu Cristea
Claudiu Cristea
Hm, I'll have to coordinate with @saidatom. The way we're getting the pushed files list is different
Also, in this PR there's a feature that allows to configure which Git hooks to be initialized. For me, personally, checking on each commit is too agresive. I only want...
@veewee, I have discussed with @saidatom. Until we decide the way to go, I'll continue to improve this. Regarding https://github.com/phpro/grumphp/pull/1136/files#r1608281196, I need to understand more what you are proposing there....
@veewee > Indeed: the hook script is activated on both commit and push. Which task is being executed will depend on a per task configuration with default if not set....
I think the tests were not enabled so I couldn't continue. But I've missed that they were enabled in the meantime
Last commit deserves better test coverage
I think I have something but no idea how add a new League container service in tests, see AutowireArgumentsTest::testWithDrushContainer()
@amitaibu, I’ve created https://www.drupal.org/project/og/issues/3467694 to run tests on drupal.org GitLab CI and archive this repository. The issue is ready for review
@amitaibu forgot to mention that prior review, 8.x-1.x branch needs to be aligned from GitHub to drupal.org. It contains last commit not synchronized. I'm not a maintainer, could you, please,...