jingo icon indicating copy to clipboard operation
jingo copied to clipboard

Author name and email in git commits are incorrect if user's display name contains '<', '>'

Open Feufochmar opened this issue 6 years ago • 1 comments

This is an abuse based on the ability on some social networks to change the display name at any moment and use < and > in them. Github allows this for instance.

This issue could be used to hide the real email adress or usurpate the identity of another user when editing the wiki, by setting the display name to something like user <[email protected]>. With this example, the name and email that will be used in git commits are user and [email protected] instead of user <[email protected]> and [email protected].

I'm unsure how this should be corrected, as there is a git limitation. If the name field contains < and > in the .gitconfig file, those are removed in the author's name field when commiting. So a user putting user <[email protected]> in the name field of their .gitconfig will be shown as user [email protected] in commits.

Feufochmar avatar Apr 06 '18 14:04 Feufochmar

Urgh... that could really be an issue :/

I will tentatively label this as a bug and will take a deeper look at it. Thanks for reporting.

claudioc avatar Aug 04 '18 16:08 claudioc