jingo icon indicating copy to clipboard operation
jingo copied to clipboard

Custom google authentication redirectUrl gives 404

Open cbebry opened this issue 8 years ago • 1 comments

I setup jingo with google authentication, set the redirectUrl originally to /auth/google/callback, and setup my google developer console to point there as well. When the authentication process completed, the redirectUrl brought me to a 404 page on my wiki instead of completing the login. When I switched both google developer console and redirectUrl to /oauth2callback, it worked fine.

I perused through https://github.com/claudioc/jingo/blob/master/routes/auth.js and noticed that the custom redirectUrl is never given a reference to the router.get(). I see that it is being passed to passport, but I'm not sure if this ends up as an endpoint to express. I could be wrong though because I am not an expert with express by any means.

I'd like to note that this isn't a big deal, but just something I noticed and figured would be helpful to mention. Thanks for all your hard work on this project.

cbebry avatar Mar 04 '16 00:03 cbebry

Thank you for taking some time to enter the details of this problem! I will take a look at this issue as soon as possible :+1:

claudioc avatar Mar 09 '16 21:03 claudioc