react-tiny-virtual-list icon indicating copy to clipboard operation
react-tiny-virtual-list copied to clipboard

Warnings when using custom prop to force update

Open bvisness opened this issue 5 years ago • 2 comments

I am using a custom prop to force my list to re-render, as recommended in the readme. However, doing so causes me this warning:

Warning: React does not recognize the isScrolling prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase isscrolling instead. If you accidentally passed it from a parent component, remove it from the DOM element.

(my prop is called isScrolling)

bvisness avatar Jul 20 '18 16:07 bvisness

I was able to suppress the warning by naming my attribute data-is-scrolling. It might be nice to mention something about this in the docs.

bvisness avatar Jul 24 '18 12:07 bvisness

👍 Good point. I think having a forceUpdate prop would make sense, this way we could explicitly exclude it from the passthrough props that are passed to the wrapper. If this is something you have time to tackle, I'd be happy to accept a PR to that effect. Otherwise I'll try to get around to it at some point 😅

clauderic avatar Jul 31 '18 20:07 clauderic